Discord mention parsing is greedy

[DanielRX]

Context:
Within a discord server that has a member with username 13#XXXX

If I do $remind discordUser in 30s Hello and their discord id is: 13XXXXXXXXXXXXXXXX, when the command resolves, it will ping the 13#XXXX user, not the user I targeted with $remind (the discordUser)

[Supinic]

If I understand this correctly, this is the sequence of steps you're describing:

1. user A discord ID is e.g. 13xxx
2. user B's discord name is 13#tag
3. $remind (user A) hello
4. When the reminder is received, the mention in that reminder does not target user A, but rather user B - seemingly because of the mimatch between the name and the ID

If this is correct, I would appreciate if both those users would join my Discord server, so I can simulate this behaviour

[Supinic]

After a brief demonstration by @DanielRX on Discord, I figured out what is wrong:

supibot/controllers/discord.js

Line 276 in 18605ce

const regex = new RegExp(`@${sb.Utils.escapeRegExp(name)}`, "gi");

Fired reminders will attempt to ping a user by establishing a mention in the <@(user-id)> format inside of their message string. When attempting to send the message however, the abovementioned regex replaces the internals of the mention - by not checking for a preceding < character.

[Supinic]

Fixed in c678672 - forgot to link commit with this issue