Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only make sounds on input #1

Closed
dvcrn opened this issue Apr 30, 2015 · 2 comments
Closed

Only make sounds on input #1

dvcrn opened this issue Apr 30, 2015 · 2 comments

Comments

@dvcrn
Copy link

dvcrn commented Apr 30, 2015

Amazing plugin 馃槃

I think it would be a bit better if the sound only happens when you actually input stuff rather than command / ctrl / meta keys. That usually ends up in having 2 sounds at the same time for making brackets.

Just my 2 cents!

@surdu
Copy link
Owner

surdu commented Apr 30, 2015

Thanks 馃榿

I had this in mind, but if you think about it, the backspace and space keys on the typewriter also makes the clank sound although it makes no visible output.

You can think of it like this: your keyboard is a typewriter, it will clank whatever you press.

Maybe I'll make it as an option, though I think I'll keep it as simple as possible 馃構

I'll leave this open for now, until I give it a deeper thought 馃槈

@surdu
Copy link
Owner

surdu commented Feb 25, 2018

I'll close this for now. I'm still on the same opinion that:

the backspace and space keys on the typewriter also makes the clank sound although it makes no visible output

Judging by the lack of thumbs up or other input on this I'll assume not many want this feature.

If there are more people that desire this kind of behaviour or someone creates a pull request for it, I'll be glad to help.

@surdu surdu closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants