Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of Memory Error #35

Closed
luhis opened this issue Nov 14, 2019 · 5 comments
Closed

Out of Memory Error #35

luhis opened this issue Nov 14, 2019 · 5 comments

Comments

@luhis
Copy link
Contributor

luhis commented Nov 14, 2019

I updated to v2.3.0 and now I get out of memory errors when i try to edit C#.

Example page:
https://codegolf.club/demo

just typing in random text in the Monaco editor will cause the out of memory error to happen.

@suren-atoyan
Copy link
Owner

Screen Shot 2019-11-15 at 14 00 45

I see you had another change after updating the package version. Can I ask you to downgrade the package version, to be sure that the problem is definitely in the new version? And also please note which one is the latest "right" working version of the package.

Thank you!

@suren-atoyan
Copy link
Owner

Why I am asking this is because here is an example of ControlledEditor (which you are using) in version 2.3.0, and, as I saw, everything is okay so far.

@luhis
Copy link
Contributor Author

luhis commented Nov 16, 2019

you are right, rolling back React Monaco doesn't fix it. I can see what's happening now. It keeps emitting on change events, so it creates a feedback loop and runs away. I can see in the logs that the loops are alternating last char missing, last char present. I will probably just move to the uncontrolled input and that should solve the problem

@suren-atoyan
Copy link
Owner

Okay. And Please let me know if everything is okay, and we can close the issue.

@luhis
Copy link
Contributor Author

luhis commented Nov 19, 2019

so, i have left it as the controlled editor, but just removed the feedback of the state into the Editor component, so it is no longer crashing, but I don't think it is working correctly. I will have another look at it when i have some time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants