This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Remove header component examples workaround for missing serviceUrl #68

Closed

andymantell opened this issue Jun 2, 2020 · 1 comment

Labels

Collaborator

andymantell commented Jun 2, 2020

A workaround has been added to https://github.com/surevine/govuk-react-jsx/blob/master/src/govuk/components/header/examples.js to tweak the examples and resolve an issue with the html diffing caused by a missing serviceUrl param/prop.

Once alphagov/govuk-frontend#1825 is merged and released, this workaround should be removed.

andymantell added the tech-debt label

Collaborator Author

andymantell commented Jul 30, 2020

Fixed by b8b968b

andymantell closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.