Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LiveViewNative? #708

Open
mayel opened this issue Sep 8, 2023 · 5 comments
Open

Support for LiveViewNative? #708

mayel opened this issue Sep 8, 2023 · 5 comments

Comments

@mayel
Copy link
Contributor

mayel commented Sep 8, 2023

As LVN is almost ready for production I was wondering if anyone's tried using Surface for it, and if not yet doable what changes would be needed?

One aspect of it would be being able to have multiple markup files for the same component/view:

  • my_component.sface
  • my_component.swiftui
  • my_component.jetpack
  • etc
@mayel
Copy link
Contributor Author

mayel commented Sep 17, 2023

So gave it a shot and the good news is that it mostly works! :)

Surface and LiveViewNative happily live side by side in components and views. E.g.:

        use Surface.Component
        use LiveViewNative.Component

The only thing that doesn't seem to work is collocating .sface and LVN files as I mentioned above and documented here: https://hexdocs.pm/live_view_native/render-patterns.html#external-template-files

This works in the meantime, though I'd still prefer being able to have separate files:

  def render(%{platform_id: :swiftui} = assigns) do
    # This UI renders on the iOS/Mac app
    ~SWIFTUI"""
    <VStack>
      <Text>
        Hello native!
      </Text>
    </VStack>
    """
  end

  def render(assigns) do
    assigns
    |> render_sface()
  end

@mayel
Copy link
Contributor Author

mayel commented Sep 17, 2023

@noozo
Copy link

noozo commented Oct 13, 2023

i think it mostly works, the main issue RN is layouts, me thinks.

@mayel
Copy link
Contributor Author

mayel commented Oct 13, 2023

@noozo I had no issues doing this for the live layout:

defmodule MyApp.Web.LayoutLive do
        use Surface.Component
        use LiveViewNative.Component

  def render(%{platform_id: :swiftui} = assigns) do
    # This renders a layout for the iOS/Mac app
    ~SWIFTUI"""
    <VStack>
      <%= @inner_content %>
    </VStack>
    """
  end

  def render(assigns) do
  # This layout renders for the web (with Surface)
    ~F"""
    <div
      id="layout_live"
[...]

@mayel
Copy link
Contributor Author

mayel commented Dec 21, 2023

With the LiveViewNative 0.2 beta, there's a PR to get layouts working: liveview-native/live_view_native#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants