Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network services were upgraded #95

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

erikbasargin
Copy link
Collaborator

@erikbasargin erikbasargin commented Apr 22, 2021

Description

Added just simpler version of the network layer. From this moment services are responsible only for making requests and general configurations. For example, StackexchangeNetworkService gives us availability to make get requests to the stack exchange server with common query params.

How has this been tested?

  1. Open the app
  2. Check that everything is fine

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Closes #89

@erikbasargin erikbasargin added High High priority hotfix labels Apr 22, 2021
@erikbasargin erikbasargin added this to the Main Flow milestone Apr 22, 2021
@erikbasargin erikbasargin self-assigned this Apr 22, 2021
@erikbasargin erikbasargin added this to In progress in StackOv 2.0 MVP via automation Apr 22, 2021
@erikbasargin erikbasargin merged commit fdc4262 into develop Apr 22, 2021
StackOv 2.0 MVP automation moved this from In progress to Done Apr 22, 2021
@erikbasargin erikbasargin deleted the hotfix/89-network-service-upgrade branch April 22, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High High priority hotfix
Projects
Development

Successfully merging this pull request may close these issues.

New network layer
1 participant