Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Modulation From" menu item #2428

Closed
baconpaul opened this issue Aug 4, 2020 · 5 comments · Fixed by #2431
Closed

"Add Modulation From" menu item #2428

baconpaul opened this issue Aug 4, 2020 · 5 comments · Fixed by #2431
Labels
Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@baconpaul
Copy link
Collaborator

When you RMB on a slider lets add a menu called "Add Modulation From"

Looks like

Add Modulation From > LFO1
LFO2

etc...

the list of submenus is all the controls which are available but which are not currently modulating the parameter.

It would them pop up the enter modulation button for that.

Idea from ENV1 on KVR. Good idea too.

@baconpaul baconpaul added the Feature Request New feature request label Aug 4, 2020
@mkruselj mkruselj added the Modulation Modulation related issues label Aug 4, 2020
@mkruselj
Copy link
Collaborator

mkruselj commented Aug 4, 2020

Indeed good stuff. Of course, that menu shouldn't show if all modulators are already (for whatever reason!) modulating the parameter.

@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Aug 4, 2020
@baconpaul
Copy link
Collaborator Author

Yeah that's right.
Making the patch to test that edge case would be really hard if we didn't have this menu. but once we have it it's an easy test :)

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 4, 2020

This part in SGE should really help:

image

Basically if n_ms here equals n_modsources it means all modulators have already been assigned to that parameters and we don't show that menu!

@baconpaul
Copy link
Collaborator Author

yeah that's right!

I meant 'setting up a patch that tests that will be easier if we have it'. Otherwise i have to activate all the mod sources!

This is a neat feature.

@mkruselj
Copy link
Collaborator

mkruselj commented Aug 4, 2020

image

Yep, it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request Modulation Modulation related issues UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants