Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter balance behavior is borked #2606

Open
mkruselj opened this issue Sep 10, 2020 · 1 comment
Open

Filter balance behavior is borked #2606

mkruselj opened this issue Sep 10, 2020 · 1 comment
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) DSP Issues and feature requests related to sound generation in the synth Feature Request New feature request
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Sep 10, 2020

Currently, filter balance parameter works in a very very unexpected way compared to other synths that have this feature.

Namely, it does not only mix between the filter outputs themselves, it also mixes what comes into the filters in the same way. So, for example, if we route oscillator 1 into both filters, and we use Serial 1 configuration, the expectation is that filter balance would mix between output of filter 1 (which is just osc 1 into filter 2) and output of filter 2 (which would in this configuration be osc 1 into filter 1, then into waveshaper, then into filter 2, summed with dry osc 1 again).

However, what we actually get is that as you move filter balance from F1 to F2, osc 1 input into filters 1 and 2 is also mixed, so with filter balance at max (filter 2 only), we ONLY hear osc 1 going into filter 2, without any prior processing by filter 1 and the waveshaper there. Highly uncommon!

Proposed solution for this would be adding a RMB parameter on Filter balance parameter that would disable this coupling between filter input and output mixing, and only do mixing of outputs. Paul said that this is pretty tricky because a new argument needs to be threaded into QuadFilterChain, and do some (a decent amount of) SSE to make it happen. So let's mark this one as a potential candidate for 1.9!

@mkruselj mkruselj added Feature Request New feature request DSP Issues and feature requests related to sound generation in the synth labels Sep 10, 2020
@mkruselj mkruselj added this to the 1.7.n milestone Sep 10, 2020
@mkruselj mkruselj modified the milestones: 1.8.n, 1.9.0 Oct 8, 2020
@mkruselj mkruselj added Requires Param List Change To accomplish this issue we need to be able to modify the DAW params in all our hosts and removed Requires Param List Change To accomplish this issue we need to be able to modify the DAW params in all our hosts labels Dec 23, 2020
@mkruselj mkruselj modified the milestones: 1.9.0, Surge XT Jan 24, 2021
@mkruselj
Copy link
Collaborator Author

mkruselj commented Sep 21, 2021

This issue is a subset of #4355, so linking to it before closing this one.

@mkruselj mkruselj removed this from the After Surge XT 1.0 milestone Oct 27, 2021
@mkruselj mkruselj changed the title Add option for more expected filter balance behavior Filter balance behavior is borked Sep 22, 2022
@mkruselj mkruselj added the Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) label Sep 22, 2022
@mkruselj mkruselj reopened this Sep 22, 2022
@mkruselj mkruselj added this to the Surge XT 2.0 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change In order to close this issue we need to make a breaking change (no backwards compatibility) DSP Issues and feature requests related to sound generation in the synth Feature Request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant