Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://surge-synthesizer.github.io/ says "Download for null" #6364

Closed
yurivict opened this issue Jul 15, 2022 · 5 comments
Closed

https://surge-synthesizer.github.io/ says "Download for null" #6364

yurivict opened this issue Jul 15, 2022 · 5 comments
Labels
Bug Report Item submitted using the Bug Report template

Comments

@yurivict
Copy link

What does this mean?
image

I think it meant to say "Download for FreeBSD" and link to https://www.freshports.org/audio/surge-synthesizer-xt-lv2/

OS: FreeBSD 13.1

@yurivict yurivict added the Bug Report Item submitted using the Bug Report template label Jul 15, 2022
@mthierman
Copy link
Contributor

Well, looks like we check for the following platforms:

      platform = window.navigator.platform,
      macosPlatforms = ["Macintosh", "MacIntel", "MacPPC", "Mac68K"],
      windowsPlatforms = ["Win32", "Win64", "Windows", "WinCE"],
      iosPlatforms = ["iPhone", "iPad", "iPod"],
      os = null;

so null = anything not the above. Not sure what our policy is about linking unofficial builds but could add if the team is OK with that and if we are able to detect with window.navigator.

We should at least do something better than null.

@yurivict
Copy link
Author

FYI: window.navigator.platform on FreeBSD evaluates to FreeBSD amd64.

@mthierman
Copy link
Contributor

mthierman commented Jul 15, 2022

Cool, thanks for checking! I have no problem adding other platforms with unofficial links, what does the team think? I'm sure everyone using these systems know it's unofficial but we could add a note as well.

Null is not a good experience regardless.

@mkruselj
Copy link
Collaborator

mkruselj commented Jul 15, 2022

Website related issues should go here, first and foremost. Please reopen this issue there, for consideration. Thanks!

At any rate, the intention behind that download button was not to link to external sites with unofficial downloads that are managed by a 3rd party outside of Surge Synth Team.

@haenkel
Copy link
Contributor

haenkel commented Jul 15, 2022

@mthierman you can link here:
https://github.com/surge-synthesizer/surge-synthesizer.github.io/wiki/Linux-and-other-unix-like-distributions#surge-on-freebsd
and replace the (outdated) wiki part with:

## Surge on FreeBSD

The FreeBSD port is available at: https://www.freshports.org/audio/surge-synthesizer-xt-lv2/

Users can install it with the command: <br/>
`pkg install surge-synthesizer-xt-lv2` (using a binary package) <br/>
`cd /usr/ports/audio/surge-synthesizer-xt-lv2 && make install clean`
(build and install from source)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

No branches or pull requests

4 participants