Surge-VST2: (macOS) Non-constant-expression cannot be narrowed from type 'int' to 'char' in initializer list

[esaruoho]

am trying to get macOS VST2 to compile and am getting this error in audioeffect.cpp:

Non-constant-expression cannot be narrowed from type 'int' to 'char' in initializer list

What should I do about it?

[esaruoho]

Xcode suggests fixing it, so.. if I click on Fix, this:

char temp[2] = {'0' + (char)digit, '\0'};

changes into this:

char temp[2] = {static_cast<char>('0' + (char)digit), '\0'};

is this overall something safe that I can commit to the repo?

[baconpaul]

That change is OK but a bit weird looking. If I were reviewing the code I would suggest you make it clearer with

Char tmp[ 2 ];
Tmp[ 0 ] = (char)( ‘0’ + (char) digit ); // so 0-9 goes to ‘0’ - ‘9’; and 10 goes to ‘a’
Tmp[ 1 ] = ‘\0’;

Which is basically the same thing just a bit more readable. I’d also ask if someone had confirmed that 0 <= digit < 10 somewhere earlier in the code.

[esaruoho]

@asimilon how did you solve this issue on your branch? :o

[asimilon]

The only source changes I had to make were removing experimental:: from std::filesystem, like this:

#if MAC
 namespace fs = std::filesystem;
#else
 namespace fs = std::experimental::filesystem;
#endif

everything else compiled as is (for VST2, VST3 had a ton of errors, and AU wouldn't go anywhere due to missing files).

[esaruoho]

@asimilon is this change in a PR and has it been merged? if so, i could always close this ticket :)

[asimilon]

Those changes I detailed above aren't necessary any more (for me at least). I was building successfully without them (XCode9 and brew llvm) after the #92 merge.

[esaruoho]

ok, closing ticket :)