Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Move Build Phase scripts into script files #43

Closed
4 tasks done
surpher opened this issue Oct 15, 2020 · 3 comments · Fixed by #59
Closed
4 tasks done

Task: Move Build Phase scripts into script files #43

surpher opened this issue Oct 15, 2020 · 3 comments · Fixed by #59
Assignees
Labels
good first issue Good for newcomers tech Something technical that doesn't fit a feature or enhancement Trivial Some change that is trivial

Comments

@surpher
Copy link
Owner

surpher commented Oct 15, 2020

❕ Problem Statement

macOS target contains a couple of Build Phase scripts that are written in the Build Phase themselves. This is not ideal and should be pulled out into a script file.

💬 Task Description

Pull out the scripts in Build Phases into script files and move into /Scripts/BuildPhases:

Targets:

  • PactSwift_macOS
  • PactSwift_iOS

BuildPhases:

  • Cargo build (libpact_mock_server.a)
  • Move the "check for rust" block of code in ./Scripts/build_file_list_and_swiftlint file into it's own script file to be individually referenced from either a BuildPhase or GitHub workflow step

👩‍🔧 Technical Design Notes

  • No scripts that are called from Build Phase are to install anything - it should only check for availability of the tools and stop the build (eg: non zero return from script) if required tools are missing, and clearly display what the problem is.
  • Build Phase script should reference the script file to run
  • See Build Phase Swiftlint and ./Scripts/BuildPhases for guidance
  • Script filenames to not contain extension (eg. .sh) as first line in the script should imply it's a shell script.

🤝 Relationships

@surpher surpher added good first issue Good for newcomers tech Something technical that doesn't fit a feature or enhancement Trivial Some change that is trivial hacktoberfest labels Oct 15, 2020
@surpher surpher changed the title Task: ... Task: Move Build Phase scripts into script files Oct 15, 2020
@iAshishChauhan
Copy link

Hey, I would like to give it a shot! Can you please assign this to me?

@surpher
Copy link
Owner Author

surpher commented Oct 16, 2020

Thanks! 👍

I have added a few more details so it should be easier to complete this task.

@surpher surpher added this to In progress in Hacktoberfest Oct 17, 2020
@surpher
Copy link
Owner Author

surpher commented Oct 17, 2020

I have made some minor changes to existing PactSwift_macOS scheme and its Build Phases in #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tech Something technical that doesn't fit a feature or enhancement Trivial Some change that is trivial
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants