Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support macOS architecture #16

Closed
surpher opened this issue Apr 30, 2020 · 2 comments
Closed

Support macOS architecture #16

surpher opened this issue Apr 30, 2020 · 2 comments
Assignees
@surpher
Labels
enhancement New feature or request
Projects
Beta release - consumer

Comments

@surpher
Copy link
Owner

surpher commented Apr 30, 2020 •
edited
Loading

Currently only iOS architecture is supported.

Add support to run Pact tests for macOS platform using Carthage as dependency manager.

Ideally generate a fat framework that supports multiple architectures. This will avoid confusion when importing/using the frameworks on the framework user (eg: linking to /Carthage/build/iOS/, and/or /Carthage/build/mac/ locations, then seeing two frameworks with same name in Xcode project navigator).
@surpher surpher added the enhancement New feature or request label Apr 30, 2020
@surpher surpher pinned this issue Apr 30, 2020
@surpher surpher added this to To do in Beta release - consumer via automation Apr 30, 2020
@surpher surpher moved this from To do to In progress in Beta release - consumer Apr 30, 2020
@surpher surpher moved this from In progress to To do in Beta release - consumer Apr 30, 2020
@surpher surpher moved this from To do to In progress in Beta release - consumer May 3, 2020
@surpher surpher self-assigned this May 5, 2020
@surpher
Copy link
Owner Author

surpher commented May 8, 2020

macOS target added and unit tests within the framework seem to work.

Commit hash: e86688c

Hitting issues setting up a demo project for macOS architecture, PactSwift added as a dependency using Carthage.

@surpher
Copy link
Owner Author

surpher commented May 14, 2020 •
edited
Loading

The issue was with Sandboxing. Given a macOS app is not sandboxed, any path on the disk is fair game. Which is not ideal.

Solution is to write into NSHomeDirectory()/Documents only for macOS.
iOS/tvOS does not present with same issue.

Fixed with commit hash: 41c5d0b

@surpher surpher unpinned this issue May 14, 2020
@surpher surpher closed this as completed May 14, 2020
Beta release - consumer automation moved this from In progress to Done May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surpher surpher

Labels
enhancement New feature or request
Projects
No open projects
Beta release - consumer
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@surpher