Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize rpc query #2

Closed
wants to merge 1 commit into from
Closed

Conversation

dector
Copy link

@dector dector commented Sep 13, 2022

Replacing \n with spaces for query() method.

(I'm not sure that it's not a workaround-ish however.)

Closes #1

@korkje
Copy link

korkje commented Sep 16, 2022

This would break queries with e.g. conditions that data should contain newlines, no? 🤔 Not the most common use case to be sure, but a perfectly valid one. A fix like this one should probably make sure to only remove newlines outside of conditions and the like.

@dector
Copy link
Author

dector commented Sep 16, 2022

@korkje I think you are right. Closing

@dector dector closed this Sep 16, 2022
@dector dector deleted the fix/multine-query branch September 16, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request hangs if query is multine in backticks
2 participants