Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update repository/contributor docs #23

Closed
3 of 4 tasks
oberbeck opened this issue Sep 18, 2022 · 6 comments · Fixed by #58
Closed
3 of 4 tasks

update repository/contributor docs #23

oberbeck opened this issue Sep 18, 2022 · 6 comments · Fixed by #58

Comments

@oberbeck
Copy link
Contributor

oberbeck commented Sep 18, 2022

In #19 we discuss how to document the usage of this library.
In addition, we should also have some documentation for this repository. Here, I am thinking about

  • repo structure
  • requirements
  • build/dev instructions
  • note on supported environments

I believe this is especially needed as we are mixing Deno, NodeJS, etc. in a project which is quite unusual.

@VixieTSQ
Copy link

repo structure

sounds like a thing solely for contributors.

requirements

What requirements?

Could probably also add code example to the list.

@mathe42 mathe42 mentioned this issue Sep 19, 2022
@oberbeck
Copy link
Contributor Author

repo structure

sounds like a thing solely for contributors.

That's what I mean - documentation for contributors. Everything else (lib user facing) I see as part of #19

@VixieTSQ
Copy link

repo structure

sounds like a thing solely for contributors.

That's what I mean - documentation for contributors. Everything else (lib user facing) I see as part of #19

Ahh, the distinction between the two issues was unclear. This could probably use a better title

@oberbeck oberbeck changed the title update repository docs update repository/contributor docs Sep 19, 2022
This was referenced Sep 19, 2022
@mathe42
Copy link
Contributor

mathe42 commented Sep 19, 2022

What is "repo structure" for you? / What is missing to close this?

@oberbeck
Copy link
Contributor Author

What is "repo structure" for you? / What is missing to close this?

I was thinking about the usual stuff. Things like the general folder structure, naming conventions, and so on.

@VixieTSQ
Copy link

What is "repo structure" for you? / What is missing to close this?

I was thinking about the usual stuff. Things like the general folder structure, naming conventions, and so on.

You should probably be able to intuit all that stuff by just looking at the code. Codebases usually have a good starting point when trying to understand them, such as the Surreal class in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants