Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check on connect #84

Closed
netcodedev opened this issue Apr 12, 2023 · 5 comments · Fixed by #262
Closed

Compatibility check on connect #84

netcodedev opened this issue Apr 12, 2023 · 5 comments · Fixed by #262
Labels
enhancement New feature or request

Comments

@netcodedev
Copy link

Switching from beta 8 to beta 9 caused a lot of trouble which made me think that it might be nice if the library had some type of compatibility check when connecting to the server.

@kearfy
Copy link
Member

kearfy commented Apr 13, 2023

Hi @netcodedev, while I like your suggestion, keep in mind that surrealdb is still in beta! There was a slight hickup because of a change in the websocket protocol. I patched it first thing this week after easter and we put out the v0.6.0 release of the library Tuesday evening.

Once a stable 1.0.0 release is out the protocol will stay backwards compatible until a new major release. Hope that helps!

Edit: would also like to add: I don't think there is actually an endpoint to check the version of surrealdb as of now

@kearfy kearfy closed this as completed Apr 13, 2023
@netcodedev
Copy link
Author

Hi @kearfy
Thank you for your quick reply. While I still mostly agree and of course know that surrealdb is still in beta I hope you may still keep this suggestion in mind. As you already mentioned the protocol will stay backwards compatible, but only until a new major release. But this is exactly the situation where things might break and imo it would slightly improve DX if there was some kind of notice that an outdated library version might cause trouble when connecting to an updated instance of surrealdb.

Anyways thank you for your work on this great project 💕

@kearfy
Copy link
Member

kearfy commented Apr 13, 2023

We will definitely keep it in mind, if a method get's created for this in the protocol we can always reconsider!

@kearfy
Copy link
Member

kearfy commented Apr 13, 2023

Seems like an API for checking the version is already implemented after all, I'll get this implemented soon for a check probably between 1.0.0-beta.8 and 2.0.0

AKA; it might still break during the development before 1.0.0, but should be solid afterwards!

@kearfy kearfy reopened this Apr 13, 2023
@netcodedev
Copy link
Author

Great to hear!

@kearfy kearfy added the enhancement New feature or request label Jun 13, 2023
@kearfy kearfy mentioned this issue May 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants