Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Surreal REPL - empty string shouldn't be sent to server #147

Closed
2 tasks done
chammika-become opened this issue Sep 14, 2022 · 1 comment
Closed
2 tasks done
Milestone

Comments

@chammika-become
Copy link

Is your feature request related to a problem?

REPL error at empty string. Ideally, I should be able to keep pressing enter just to make room for my next query 馃槃. similar to mysql REPL. Simple change in REPL code as I observed.

Now:

>
{"code":400,"details":"Request problems detected","description":"There is a problem with your request. Refer to the documentation for further information.","information":"There was a problem with the database: Specify some SQL code to execute"}

Better:

>
>
>

Feature request after discussion with @tobiemh #145

Describe the solution

Check for empty string in REPL loop at src/cli/sql.rs

Alternative methods

Above solution is simple enough.

SurrealDB version

surreal 1.0.0-beta.7 for macos on aarch64

Contact Details

@chammika-become

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tobiemh
Copy link
Member

tobiemh commented Sep 14, 2022

Thanks for submitting this feature request @chammika-become 馃榾馃憦!

@tobiemh tobiemh added this to the v1.0.0-beta.8 milestone Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants