nix: fix darwin build

[happysalada]

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

The flake is amazing, however it doesn't build on darwin (macos)

What does this change do?

This fixes the build for darwin platforms. tested only on x86_64 though.

What is your testing strategy?

run nix build .#packages.x86_64-darwin.default on a darwin machine and verify the output of ./result/bin/surreal version

Is this related to any issues?

If this pull request is related to any other pull request or issue, or resolves any issues - then link all related pull requests and issues here.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

[happysalada]

@rushmorem you might be interested in this.

[rushmorem]

Awesome! Thanks @happysalada. This was something on my TODO list.

[tobiemh]

Any ideas why this build is failing @rushmorem ?

[rushmorem]

Any ideas why this build is failing @rushmorem ?

By specifying the build inputs where they specified them, they are overriding all the build inputs from all the targets, hence it's now failing to find the FoundationDB library. Unfortunately, I noticed this after approving the PR and I couldn't figure out how to un-approve. They will need to address my comment to fix this.

[happysalada]

I see, I didn't know about the specific files. @rushmorem that should do it IIUC .
Let me know if anything else.

[rushmorem]

I see, I didn't know about the specific files. @rushmorem that should do it IIUC . Let me know if anything else.

It's OK. This now looks good to me.

[happysalada]

It s complaining that the apple framework is not available for Linux. Even though its in the Darwin file, should I add a lib.optional Darwin for those dependencies ?

[rushmorem]

It s complaining that the apple framework is not available for Linux. Even though its in the Darwin file, should I add a lib.optional Darwin for those dependencies ?

I think it might be cleaner to just remove the Nix lint.

[happysalada]

Just removed the nix lint workflow, let me know if you had something else in mind.

[rushmorem]

Just removed the nix lint workflow, let me know if you had something else in mind.

Thanks @happysalada. That's exactly what I meant 👍

Would you mind removing the needs: lint lines too from the 3 jobs in the same workflow?

[happysalada]

forgot to check for that :-) , done!

[rushmorem]

forgot to check for that :-) , done!

Thanks!

[happysalada]

it looks like the workflow didn't trigger after the approval somehow.

[rushmorem]

it looks like the workflow didn't trigger after the approval somehow.

It's waiting for @tobiemh's approval.