Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Current/Maximum Allowed Characters when a maximum length is defined for input fields #5436

Closed
JaneSjs opened this issue Dec 29, 2022 · 1 comment · Fixed by #5670
Closed

Display Current/Maximum Allowed Characters when a maximum length is defined for input fields #5436

JaneSjs opened this issue Dec 29, 2022 · 1 comment · Fixed by #5670
Assignees
@OlgaLarina @mikeamelin
Labels
enhancement
Milestone
v1.9.75

Comments

@JaneSjs
Copy link
Contributor

JaneSjs commented Dec 29, 2022 •
edited

Usage scenario: Text input fields (e.g., Text, Comment questions) define the maxLength property:

{ 
   "elements": [
    {
     "type": "text",
     "name": "question1",
     "maxLength": 5
    }
   ] 
}

Display the Current/Max allowed characters for input fields.
image
@mikeamelin
Copy link

Design — https://www.figma.com/file/7QOeoDDCaPuqzWAROR0kDY/SJS-Creator?node-id=15561%3A133259

@OlgaLarina OlgaLarina self-assigned this Jan 10, 2023
@OlgaLarina OlgaLarina added this to the v1.9.69 milestone Jan 10, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.69, v1.9.70 Jan 18, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.70, v1.9.71 Jan 26, 2023
@OlgaLarina OlgaLarina modified the milestones: v1.9.71, v1.9.72, v1.9.73 Feb 6, 2023
OlgaLarina pushed a commit that referenced this issue Feb 15, 2023
work for #5436 Display Current/Maximum Allowed Characters when a maxi…
e0eab67 
…mum length is defined for input fields
OlgaLarina pushed a commit that referenced this issue Feb 15, 2023
work for #5436 add f-tests & visual test
4abb67c
@OlgaLarina OlgaLarina linked a pull request Feb 15, 2023 that will close this issue
Display Current/Maximum Allowed Characters when a maximum length is defined for input fields #5670
Merged
OlgaLarina pushed a commit that referenced this issue Feb 15, 2023
work for #5436 : fix markup tests & add visual test mask
2f41195
@OlgaLarina OlgaLarina modified the milestones: v1.9.73, v1.9.75 Feb 15, 2023
OlgaLarina pushed a commit that referenced this issue Feb 15, 2023
work for #5436 : fix question-comment for angular
07e85b5
tsv2013 pushed a commit that referenced this issue Feb 16, 2023
@OlgaLarina
Display Current/Maximum Allowed Characters when a maximum length is d…
aa3fa91 
…efined for input fields (#5670)

* work for #5436 Display Current/Maximum Allowed Characters when a maximum length is defined for input fields

* work for #5436 add f-tests & visual test

* work for #5436 : fix markup tests & add visual test mask

* work for #5436 : fix question-comment for angular

---------

Co-authored-by: OlgaLarina <olga.larina.dev@gmail.com>
OlgaLarina pushed a commit to surveyjs/survey-creator that referenced this issue Feb 16, 2023
fix after surveyjs/survey-library#5436
afb8618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlgaLarina OlgaLarina

@mikeamelin mikeamelin

Labels
enhancement
Projects
None yet
Milestone
v1.9.75
3 participants
@OlgaLarina @mikeamelin @JaneSjs