Loading SVG page

[hnqlv]

Hey @christianalfoni great work with this cookbook, it has been very useful. One thing we could add underneath "Loading LESS or SASS" is the "Loading SVG" page.

I know we have a few ways to achieve this using with svg-loader but the simple way to do that is through file-loader.

module: {
  loaders: [
  ...
  { 
    test: /\.svg$/, 
    loader: "file-loader" 
  },
  ...
  ]
}

Then in your CSS:

.MyIcon {
  ...
  background-image: url(../assets/my-icon.svg);
}

I know I lost a few minutes yesterday looking, it might be useful for someone else as well.

Thoughts?

Cheers

[christianalfoni]

Hi there!

Yeah, this sounds like a great idea. I have set up a an article:

https://github.com/christianalfoni/react-webpack-cookbook/wiki/Loading-SVG

It would be great if you had time to put in what you have now. Something is better than nothing :-) Then we can keep work on it if necessary? That would be awesome :-)

[hnqlv]

@christianalfoni thanks man! Sounds like a good plan, start with something then improve. Sure I can do that. I'll put something together tonight (:

[hnqlv]

@christianalfoni silly question: how do I do to edit the wiki page and/or send a PR?

[christianalfoni]

HI @henriquea,

It should be open to everyone? You just edit the page and save :-) ... or did we lock it?... yes we did. I have opened it now :-)

[hnqlv]

@christianalfoni done! https://github.com/christianalfoni/react-webpack-cookbook/wiki/Loading-SVG

By the way, the big downside of the Wiki is not be able to send PR's. Are you planning in change this structure?

Feel free to close this issue.

Cheers 🍺

[bebraw]

@henriquea Yeah, lack of PRs is a bit unfortunate. We could work around this by moving the content the main repo, closing the wiki to modifications and setting up some process to update wiki content (it's a git repo after all...) and push new builds to gh-pages.

If that sounds fine, I could probably set up that on a Raspberry Pi I have around (just cron to trigger the process a couple of times per day or so). I have a setup like this for another project.

[christianalfoni]

That sounds awesome @bebraw. The wiki gives such a nice structure, but hard to keep it consistent if everybody can just change it. So yeah, some pull system for it would be great!

[hnqlv]

@bebraw @christianalfoni agree with the lack of PR, move the wiki to the main repo makes a lot of sense for me.

[bebraw]

I set up build/deployment scripts and made my raspi to perform updates once per hour (xx:30).

@christianalfoni Can you make the wiki closed to public again? All changes should go through the main project.

Let me know if you notice any issues (missing updates etc.).

[bebraw]

@christianalfoni You should modify project homepage to point at https://christianalfoni.github.io/react-webpack-cookbook/ so it's easier to find if you stumble on page.

[christianalfoni]

You mean in README of repo? pointing to wiki? Updated that now :-)

[bebraw]

@christianalfoni I mean repo. That blank spot at next to A cookbook for using webpack with React JS at https://github.com/christianalfoni/react-webpack-cookbook index.

[christianalfoni]

Updated now, you mean like that? :-)

[hnqlv]

@bebraw @christianalfoni should we close the wiki and maybe delete its content?

[bebraw]

@christianalfoni Here:

@henriquea It's enough to close it to modifications. I set it up so that the wiki content gets generated based on the repo.

[christianalfoni]

Haha, I was not aware of that feature! Will fix it now :)

[bebraw]

@christianalfoni Can you close the wiki for modifications? Just saw an edit there which I had to move manually to main repo since it would get overwritten.

[christianalfoni]

Closed :-)

Do we have some documentation on how to contribute?

[bebraw]

Do we have some documentation on how to contribute?

Not really. I suppose we should add something to both project root readme and content/readme. The workflow should go through PRs.

[christianalfoni]

Yeah, I think that would be great. Just put it right there at the top. How does it work really? You fork and change the files in content/?

[bebraw]

Yeah, I think that would be great. Just put it right there at the top. How does it work really? You fork and change the files in content/?

Exactly. I'll add a snippet about this.