Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crawler] use $security->login() instead of goute #2

Open
tacman opened this issue Mar 28, 2023 · 1 comment
Open

[crawler] use $security->login() instead of goute #2

tacman opened this issue Mar 28, 2023 · 1 comment
Assignees
@kailashkds

Comments

@tacman
Copy link
Collaborator

tacman commented Mar 28, 2023 •
edited
Loading

https://symfony.com/blog/new-in-symfony-6-2-security-improvements-part-1

We should use this instead of the goutteClient in CrawlerService.

Crawling then becomes very similar to application testing, using the Browser client (which skips the network http calls)

see https://symfony.com/doc/6.3/testing.html#logging-in-users-authentication

This relates to #1 as well.
@tacman tacman mentioned this issue Mar 28, 2023
Open
kailashkds added a commit that referenced this issue Mar 29, 2023
@kailashkds
https://github.com/survos/survos/issues/2
ff2ffcb 
1) Added Users parameter
2) Changed CrawlerService
This was referenced Mar 29, 2023
Merged
Merged
@tacman
Copy link
Collaborator Author

tacman commented Apr 6, 2023

remove fabpot/goutte if we're not using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kailashkds kailashkds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

2-crawler-use-$security-login-instead-of-goute survos/survos
2 participants
@tacman @kailashkds