qa_crowbarsetup.sh has too many sleeps

[aspiers]

qa_crowbarsetup.sh has loads of sleep calls. This is unreliable and also typically results in everything taking longer than it should. They should all be replaced with busy waits.

[jdsn]

We totally agree :)
Most sleeps are actually meaning "FIXME, I have to be replaced by a proper query if the needed ressource is available". But we never had the time to replace them.

[aspiers]

I think some progress has been made on this, but there are still 9 sleep calls left.

[aspiers]

The remaining sleep calls are now:

• sleep 1 in resize_partition
• Three sleeps in reboot_nodes_via_ipmi
• sleep 10 in onadmin_crowbar_register
• sleep 10 in update_one_proposal
• sleep 5 in a loop oncontroller_testsetup waiting for the newly uploaded glance image to appear (should use wait_for instead) -- see PR qa_crowbarsetup: use wait_for instead of sleep-loop #1192
• sleep 60 in onadmin_cloudupgrade_reboot_and_redeploy_clients

[seife]

one sleep (not in qa_crowbarsetub, but in freshadminvm) is removed by #2564 :-)