FileRotationLogger crashes when archiving full log files

[tucknology]

Hi!

In FileRotationLogger.swift the function rotateFiles() fails at line 109 during the following instruction:

try FileManager.default.moveItem(at: fileURL, to: archivedFileURL)

This happens because in Formatter.swift the function dateFormatter(_:, locale:, dateFormat:, timeZone:) creates a timestamp that includes colons (:) which the file system does not like.

One potential solution is changing the dateFormat in line 13 of Formatter.swift from "yyyy-MM-dd'T'HH:mm:ss.SSSZZZZZ" to "yyyy-MM-dd'T'HH-mm-ss.SSS". This removes the explicit colons in the original date format string, as well as an implicit colon which is added by ZZZZZ which expands to an HH:MM style presentation of the timezone.

You might also consider reducing the complexity of this string further, since I'd argue if a detailed timestamp is necessary then it can be placed inside the log file, rather than in the file name.

One alternative could be to structure like this:

myLog.log
myLog.log.1
myLog.log.2

This proposal would simplify the implementation of the rest of the rotateFiles method that is concerned with removing old archived files.

[sushichop]

@tucknology
Thanks for reporting this. I decided not to use colon.
And for now I still want to handle the case someone wants to check the date without opening the file.
So I'll use ISO8601 basic format (no-hyphen and GMT) instead of extended format and this fixes the issue with small change.
See #11 .

One alternative could be to structure like this:

myLog.log
myLog.log.1
myLog.log.2

This is another good idea!
I'll also consider this solution in the future. It will need more big change in the code. Then I have created this issue in order to keep in mind (#12).

Thanks.

[sushichop]

I'm closing this issue since it was fixed by #11,
Feel free to reopen it or create a new issue if you will have any questions.

Thanks.

[sushichop]

One alternative could be to structure like this:

myLog.log
myLog.log.1
myLog.log.2

I have adde this feature. See #32.

Thanks.

[sushichop]

I have released Puppy@0.4.0 that fixes this issue.
Check release note and README because some specifications of FileLogger and FileRotationLogger have been changed.

Thanks.