Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage does not work when switching monitors #14

Closed
joshglazer opened this issue Mar 14, 2023 · 9 comments
Closed

Storage does not work when switching monitors #14

joshglazer opened this issue Mar 14, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@joshglazer
Copy link

If I use secureLocalStorage.setItem on one monitor, and then move my browser to a different monitor when secureLocalStorage.getItem is called, the value is not retrieved from storage. I assume this is because of the code in fingerprint.lib.ts as a few of the values in the getFingerprint() function rely on monitor settings. Would it be possible to either remove or add an option to disable the settings that can change between monitors?

@vukvukovich
Copy link

I could not replicate this one. This is how I tested it:

Created two buttons GET & SET and I was trying to change monitors accordingly.

<button onClick={() => {secureLocalStorage.setItem("foo", 'bar');}}>SET</button>
<button onClick={() => {console.log('secureLocalStorage.setItem;', secureLocalStorage.getItem("foo"))}}>GET</button>

@sushinpv
Copy link
Owner

sushinpv commented Mar 19, 2023

@joshglazer First of all, sorry for the delayed response.

We are using different browser properly to create fingure print for each browser, here the recommendation is to add as much more field as possible so that the uniqueness of the hash is more,

However I have understood your concern and we can add a .env parameter for disabling browser window screen check. This feature will be releasing on the next release

This will be purely an optional parameter as we want everyone to use as many browser properties as possible

@sushinpv
Copy link
Owner

@vukvukovich Hi, really appreciate your efforts for answering and thank you for making this community stronger.

FYI, This issue will only come when you have two monitor with two different screen size and when you SET data from one screen and refresh the website on the other screen before GETTING the data

@sushinpv sushinpv added the enhancement New feature or request label Mar 19, 2023
@joshglazer
Copy link
Author

Thanks for taking a look @sushinpv ! I'm looking forward to the next release.

Also thanks @vukvukovich for taking a look too, and sending feedback.

@sushinpv
Copy link
Owner

@joshglazer FYI , The next release is scheduled for 26th March, You can except it by 26 or on before that

@sushinpv sushinpv self-assigned this Mar 22, 2023
@sushinpv
Copy link
Owner

sushinpv commented Mar 27, 2023

Hi @joshglazer We have released a new version called 1.2.0, Now you can disable individual browser properties

To answer your question, You can use

SECURE_LOCAL_STORAGE_DISABLED_KEYS=ScreenPrint

or

REACT_APP_SECURE_LOCAL_STORAGE_DISABLED_KEYS=ScreenPrint

@joshglazer
Copy link
Author

Thank you for the quick update! This is working now.

@Souvikjr
Copy link

Getting null value from securelocalstorage after chrome update.

After saving some data in localstorage using securelocalstorage it's working perfectly but when the chrome is getting updated it's returning null value. Although the data is saved in local storage i can see the data from application tab of console. How to solve that.

@AustineA
Copy link

Getting null value from securelocalstorage after chrome update.

After saving some data in localstorage using securelocalstorage it's working perfectly but when the chrome is getting updated it's returning null value. Although the data is saved in local storage i can see the data from application tab of console. How to solve that.

Yeah i'm having similar issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants