New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added options for auto redirect/beep on session timeout. #68
Conversation
Solves the issues described here. #57 |
Before I check, can you please merge main branch into yours? Also, I was thinking it would be a lot to add any more inputs in the form. From the feedback I received, it is already confusing some people. We could have something like advanced options and by default have the voice notification enabled which tells that session is expired. The advanced options will be visible only when they click on it and for now let keep the auto logout checkbox in advanced options. What do you think @prayuj ? |
My main branch is concurrent with yours. I have just made a few changes in the beep logic which make sure that the beep plays repeatedly if the user refuses to log in again. Yes, that's a good idea. Keeping it in advanced options would reduce the clutter and make it easire to use. |
I see that you changed the audio file path that I had kept. I have removed beep if you haven't already checked. |
Okay I have corrected that. Anything else? |
I will review this tomorrow. I hope you have considered the things I suggested in the comments above. |
Yes yes, I have considered your points. It might take me some time to work on them though as I have exams coming up. |
No worries. Let's see when we can tale it forward later. All the best for your exams!! |
Yes I agree, we can place those check boxes in a collapsible "Advanced Options" which users can then configure if needed. |
@prayuj you can do
on my repo. |
Yup that worked, thanks! |
Added the option to enable the user to choose whether he wants to be redirected to the homepage automatically after session timeout or not. Redirects to the "enter phone number" page autoRedirectCheckbox is checked. Otherwise, gives a "confirm" box to the user if autoRedirect set to 0.
Also,enabled the option for the user to select whether he wants a session timeout notification beep or not.
I have tested it myself and it seems to work properly.