Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization for legendHelpers.thresholdLabels #68

Closed
existe-deja opened this issue Oct 24, 2017 · 5 comments
Closed

Internationalization for legendHelpers.thresholdLabels #68

existe-deja opened this issue Oct 24, 2017 · 5 comments

Comments

@existe-deja
Copy link

Hi,

It could be usefull to have a locale parameter for thresholdLabels. It could work the same way than timeFormat. What do you think?
@susielu
Copy link
Owner

susielu commented Nov 12, 2017

Sure, would you be interested in making a pull request?

@existe-deja
Copy link
Author

I'll manage time to do it!

@existe-deja
Copy link
Author

I forked your project and did the modification for colorLegend on my machine.
I'll be happy to make the PR and discuss about it.

@susielu
Copy link
Owner

susielu commented Nov 13, 2017

@LaCroute this is great thanks for putting at PR together. I'll take a look today and comment on it 👍

@susielu susielu closed this as completed Nov 20, 2017
@susielu
Copy link
Owner

susielu commented Nov 20, 2017

This is resolved in v2.25.0 and up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@susielu @existe-deja