Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): easier to know constraint @tanstack/react-query v4 runtimely #893

Merged
merged 3 commits into from
May 25, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented May 25, 2024

Overview

We expect version of @tanstack/react-query's as only v4. so we warn it with this change to promote installing correct version

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
main ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 11:05am
v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 11:05am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
visualization ⬜️ Ignored (Inspect) Visit Preview May 25, 2024 11:05am

Copy link

changeset-bot bot commented May 25, 2024

🦋 Changeset detected

Latest commit: 99a784e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@suspensive/react-query Patch
@suspensive/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview – visualization May 25, 2024 10:36 Inactive
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 83.44%. Comparing base (988e73b) to head (99a784e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   83.87%   83.44%   -0.44%     
==========================================
  Files          31       33       +2     
  Lines         428      435       +7     
  Branches       98       99       +1     
==========================================
+ Hits          359      363       +4     
- Misses         61       62       +1     
- Partials        8       10       +2     
Components Coverage Δ
@suspensive/react 96.98% <ø> (ø)
@suspensive/react-query 13.79% <57.14%> (+13.79%) ⬆️
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 23.52% <ø> (ø)

@vercel vercel bot temporarily deployed to Preview – main May 25, 2024 10:37 Inactive
@manudeli manudeli self-assigned this May 25, 2024
@manudeli manudeli changed the title feat(react-query): easier to know constraint @tanstack/react-query v4 runtimely fix(react-query): easier to know constraint @tanstack/react-query v4 runtimely May 25, 2024
@vercel vercel bot temporarily deployed to Preview – main May 25, 2024 10:40 Inactive
@vercel vercel bot temporarily deployed to Preview – v1 May 25, 2024 10:41 Inactive
@manudeli manudeli marked this pull request as ready for review May 25, 2024 10:52
@vercel vercel bot temporarily deployed to Preview – main May 25, 2024 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – v1 May 25, 2024 11:05 Inactive
@manudeli manudeli merged commit 39b4f1b into main May 25, 2024
15 checks passed
@manudeli manudeli deleted the react-query/tanstack-react-query-version-constraint branch May 25, 2024 11:12
@github-actions github-actions bot mentioned this pull request May 25, 2024
manudeli pushed a commit that referenced this pull request May 25, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/react-query@2.0.3

### Patch Changes

- [#893](#893)
[`39b4f1b`](39b4f1b)
Thanks [@manudeli](https://github.com/manudeli)! - fix(react-query):
easier to know constraint @tanstack/react-query v4 runtimely

-   Updated dependencies \[]:
    -   @suspensive/react@2.0.3

## @suspensive/react@2.0.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant