Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to build and push Kepler builder image #1427

Open
vprashar2929 opened this issue May 14, 2024 · 6 comments
Open

Add workflow to build and push Kepler builder image #1427

vprashar2929 opened this issue May 14, 2024 · 6 comments
Assignees
Labels
kind/feature New feature or request

Comments

@vprashar2929
Copy link
Collaborator

What would you like to be added?

A step or worklfow that builds and push the Kepler builder image so that it shouldn't be done manually

Why is this needed?

Currently, there is no workflow that builds and pushes the Kepler builder image

@vprashar2929 vprashar2929 added the kind/feature New feature or request label May 14, 2024
@vprashar2929
Copy link
Collaborator Author

@SamYuan1990 I was looking at how currently the builder image is build and pushed and came across image_base.yml workflow which I think is used in daily.yml. Can you share the idea behind why we added this workflow in daily and not on push to main branch?

@SamYuan1990
Copy link
Collaborator

@SamYuan1990 I was looking at how currently the builder image is build and pushed and came across image_base.yml workflow which I think is used in daily.yml. Can you share the idea behind why we added this workflow in daily and not on push to main branch?

we don't change it in the most of time, so seems no need for push at each time.
we'd better build ti daily to catch up CVE if possible. as 2038521#diff-1fb6f6d52a74b1f02eafeeb5d7649bdee7fadc8fdb1ff7170d58467762188212R30 we have yum update once up on a time.

@dave-tucker
Copy link
Collaborator

I'm hoping that after #1566 we can remove the builder image entirely 🙏

@SamYuan1990
Copy link
Collaborator

I'm hoping that after #1566 we can remove the builder image entirely 🙏

I suppose there different parts of builder image's responsibility.

to remove builder image... we need to ....
I suppose at least, we will have a golang image as builder to build binary?

@dave-tucker
Copy link
Collaborator

I'm hoping that after #1566 we can remove the builder image entirely 🙏

I suppose there different parts of builder image's responsibility.

to remove builder image... we need to .... I suppose at least, we will have a golang image as builder to build binary?

I believe with the changes mentioned above we can just use the RHEL UBI 9 golang image without any additional customization.

@SamYuan1990
Copy link
Collaborator

I'm hoping that after #1566 we can remove the builder image entirely 🙏

I suppose there different parts of builder image's responsibility.

to remove builder image... we need to .... I suppose at least, we will have a golang image as builder to build binary?

I believe with the changes mentioned above we can just use the RHEL UBI 9 golang image without any additional customization.

emmmm, it works for golang, but pre @rootfs told me, we want to have ebpf inside container image. how about ebpf builders like gcc/make?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants