New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TSEMO #32
Fix TSEMO #32
Conversation
…er options. Run Matlab python comparison
I've discovered a lot of subtle things about TSEMO. I want to note them here:
|
I'm done with TSEMO now. I don't think the tests will pass because one of the Gryffin tests seems to have a problem. However, otherwise, things should be working now. |
Great! Being able to use TSEMO in python now is really cool. About Gryffin: for the test functions we implemented it seems like Gryffin only gets close the optimal points but does not find those exactly. That's why the tests sometimes fail. Also, the Gryffin tests take quite long. Maybe we should comment them out in |
I think it's probably best to do the latter...maybe we can just run a few
iterations of TSEMO and Gryffin to see if the best function values are
improving. We'll have to rely on running tests elsewhere to confirm they
perform correctly on benchmarks.
…On Wed, 15 Jul 2020 at 00:13, Jan Rittig ***@***.***> wrote:
Great! Being able to use TSEMO in python now is really cool.
About Gryffin: for the test functions we implemented it seems like Gryffin
only gets close the optimal points but does not find those exactly. That's
why the tests sometimes fail. Also, the Gryffin tests take quite long.
Maybe we should comment them out in test_strategies.py or rather just
look whether the code runs without errors but exclude the full optimization
runs (this would be comment out lines: 597, 601, 673, 677).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#32 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGF3ORZCUZYFYI7NOMXVMVTR3TRDBANCNFSM4M6BKMKQ>
.
|
That's a good idea! We should also do this for SOBO, I think. This should reduce the time for the pytest runs a lot. |
This is a PR for tracking improvements to TSEMO (issue #2). It is a work in progress.
I've made one change to the hypervolume reference, but I think it's still not the same as the Bradford paper.