Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many fixes #1

Merged
merged 3 commits into from Feb 6, 2013
Merged

Many fixes #1

merged 3 commits into from Feb 6, 2013

Conversation

stelcheck
Copy link
Contributor

Hi,

Fixed:

  • run-test.sh: was just not running
  • test scripts: one was having a wrong count for parse result
  • lint: code lints as per the configuration present
  • bugfix: if i have @param name {String} without a description, the parser would break. now it returns an empty string

@psq
Copy link
Contributor

psq commented Feb 6, 2013

Wow, thank you Marc! Lots a good catches :) Event, some I'm embarrassed about... I'll check in more details soon.

@psq
Copy link
Contributor

psq commented Feb 6, 2013

Looks good, before merging, would you like to add yourself as a contributor in package.json? I'll update the readme before pushing a new version.

@stelcheck
Copy link
Contributor Author

done

On Wed, Feb 6, 2013 at 11:49 AM, Pascal notifications@github.com wrote:

Looks good, before merging, would you like to add yourself as a
contributor in package.json? I'll update the readme before pushing a new
version.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13164555.

http://www.wizcorp.jp/Marc Trudel-Belisle

Chief Technology Officer | Wizcorp Inc. http://www.wizcorp.jp/

TECH . GAMING . OPEN-SOURCE WIZARDS+ 81
3-4550-1448|Websitehttp://www.wizcorp.jp/
|Twitter https://twitter.com/Wizcorp|Facebookhttp://www.facebook.com/Wizcorp
|LinkedIn http://www.linkedin.com/company/wizcorp

@stelcheck
Copy link
Contributor Author

btw, once merged when will we be able to access this fixed version through
NPM?

On Wed, Feb 6, 2013 at 12:07 PM, Marc Trudel mtrudel@wizcorp.jp wrote:

done

On Wed, Feb 6, 2013 at 11:49 AM, Pascal notifications@github.com wrote:

Looks good, before merging, would you like to add yourself as a
contributor in package.json? I'll update the readme before pushing a new
version.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13164555.

http://www.wizcorp.jp/ Marc Trudel-Belisle

Chief Technology Officer | Wizcorp Inc. http://www.wizcorp.jp/

TECH . GAMING . OPEN-SOURCE WIZARDS + 81 3-4550-1448|Websitehttp://www.wizcorp.jp/
|Twitter https://twitter.com/Wizcorp|Facebookhttp://www.facebook.com/Wizcorp
|LinkedIn http://www.linkedin.com/company/wizcorp

http://www.wizcorp.jp/Marc Trudel-Belisle

Chief Technology Officer | Wizcorp Inc. http://www.wizcorp.jp/

TECH . GAMING . OPEN-SOURCE WIZARDS+ 81
3-4550-1448|Websitehttp://www.wizcorp.jp/
|Twitter https://twitter.com/Wizcorp|Facebookhttp://www.facebook.com/Wizcorp
|LinkedIn http://www.linkedin.com/company/wizcorp

@psq
Copy link
Contributor

psq commented Feb 6, 2013

very soon after :)

psq added a commit that referenced this pull request Feb 6, 2013
@psq psq merged commit cfa788a into sutoiku:master Feb 6, 2013
@stelcheck
Copy link
Contributor Author

Wonderful!

On Wed, Feb 6, 2013 at 12:16 PM, Pascal notifications@github.com wrote:

very soon after :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13165114.

http://www.wizcorp.jp/Marc Trudel-Belisle

Chief Technology Officer | Wizcorp Inc. http://www.wizcorp.jp/

TECH . GAMING . OPEN-SOURCE WIZARDS+ 81
3-4550-1448|Websitehttp://www.wizcorp.jp/
|Twitter https://twitter.com/Wizcorp|Facebookhttp://www.facebook.com/Wizcorp
|LinkedIn http://www.linkedin.com/company/wizcorp

@psq
Copy link
Contributor

psq commented Feb 6, 2013

should be available as 0.2.0 on npmjs.org

@stelcheck
Copy link
Contributor Author

Awesome! Thanks a lot!

On Wed, Feb 6, 2013 at 12:20 PM, Pascal notifications@github.com wrote:

should be available as 0.2.0 on npmjs.org


Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-13165206.

http://www.wizcorp.jp/Marc Trudel-Belisle

Chief Technology Officer | Wizcorp Inc. http://www.wizcorp.jp/

TECH . GAMING . OPEN-SOURCE WIZARDS+ 81
3-4550-1448|Websitehttp://www.wizcorp.jp/
|Twitter https://twitter.com/Wizcorp|Facebookhttp://www.facebook.com/Wizcorp
|LinkedIn http://www.linkedin.com/company/wizcorp

@psq
Copy link
Contributor

psq commented Feb 6, 2013

and thank you!

Also updated the site with you as a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants