fix undefined "argv" when using in programatic context #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @boneskull. I think the fix should be to default argv on this line: https://github.com/sutoiku/jsdox/pull/75/files#diff-54fc5c65530eebb4dedbf48341c8905eL320. |
mrjoelkemp
added a commit
that referenced
this pull request
Nov 25, 2014
fix undefined "argv" when using in programatic context
|
@psq Mind cutting a patch release? You can just do |
|
@mrjoelkemp sure, will do shortly. |
|
0.4.4 published, should be available shortly. |
|
@psq Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Programmatic usage of
jsdoxis pretty broken; try to run it via Gulp as in the documentation example.Anyway, this will put a band-aid on the problem, so
grunt-jsdoxwill at least function.generateForDir()is too tightly coupled to the CLI and should be refactored.