Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the problem that cannot parse dicom file with SQ of undefined length #241

Closed
wants to merge 2 commits into from

Conversation

Louis296
Copy link

Hello, I find a problem when I use it to parsing dicom file. The problem occurs when parsing a dicom file with SQ of undefined length, which has an Item Delimitation Tag (FFFE, E00D) and Sequence Delimitation Tag(FFFE, E0DD). Parser could parse these tags, but it will try to read the value of these tag and regard it as an string value. Because of the length of such item is unmeaningful FFFFFFFF, the parser will read all left data as an string value and occur an EOF exception.

A simple solution is to judge the tag in function readElement, if it is Delimitation Tag, just return, not try to read the value of it. For verify this solution, I create a special dicom file, 'testdata/6.dcm' ,which only have SQ of undefined length in dataset.

For more detail information about SQ of undefined length, click here and read the Table 7.5-3

@Louis296 Louis296 changed the title fix the problem that cannot parse dicom file with SQ of undefined length and fix the problem that cannot parse dicom file with SQ of undefined length Apr 30, 2022
@Louis296 Louis296 closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant