Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error handling #58

Open
suzuki-shunsuke opened this issue Jul 23, 2020 · 0 comments
Open

improve error handling #58

suzuki-shunsuke opened this issue Jul 23, 2020 · 0 comments
Labels
breaking change enhancement New feature or request

Comments

@suzuki-shunsuke
Copy link
Owner

AS IS

  • failed to render template
    • Currently, error is ignored and isn't outputted
  • expression isn't bool
    • Currently, the config is ignored and error isn't outputted
  • failed to evaluate the expression
    • Currently, error is ignored and isn't outputted
  • failed to post a comment
    • Currently, error is ignored and isn't outputted

TO BE

  • By default, exit code is 0 but error is outputted
  • --strict exit code isn't 0
  • --quiet error isn't outputted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suzuki-shunsuke