Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .yml file ending for configuration files #1490

Open
florianmutter opened this issue Jan 31, 2024 · 3 comments
Open

Allow .yml file ending for configuration files #1490

florianmutter opened this issue Jan 31, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@florianmutter
Copy link
Contributor

Feature Overview

Allow .yml file extenstion for tfaction and tfaction-root config files

Why is the feature needed?

YAML files can have .yml or .yaml as file extension. If you name use tfaction.yml instead of tfaction.yaml the target is not picked up which is confusing at first.

Example Code

No response

Note

I guess you would need to think about situations where you have a tfaction.yml and a tfaction.yaml in the same folder

@florianmutter florianmutter added the enhancement New feature or request label Jan 31, 2024
@suzuki-shunsuke
Copy link
Owner

Thank you for your feedback.
I think you can change file names with the environment variable TFACTION_CONFIG and the configuration working_directory_file.

export TFACTION_CONFIG=tfaction-root.yml

tfaction-root.yml

working_directory_file: tfaction.yml

@florianmutter
Copy link
Contributor Author

florianmutter commented Jan 31, 2024

Ah that's nice to know. Thank you.

We had the issue that we did use .yml and had to search a while and read code to figure out what our problem was. We now changed to yaml and everything works.

The feature request was more about helping others in the same situation by either reading both files or maybe give an error or something?

@suzuki-shunsuke
Copy link
Owner

We now changed to yaml and everything works.

Sounds good.

The feature request was more about helping others in the same situation by either reading both files or maybe give an error or something?

I think reading both files is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants