feat: support PR comments for push events #390
Merged
+28
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since GitHub no longer shows commit comments in the pull request timeline [^1], it needs to find a PR associated with a commit in a push event and then post a PR comment if found in order to show comments in the pull request timeline. [^1]: github.blog/changelog/2022-08-04-commit-comments-no-longer-appear-in-the-pull-request-timeline Signed-off-by: micnncim <micnncim@gmail.com>
|
Thank you for your contribution! |
pkg/notifier/github/commits.go
Outdated
| prs, _, err := g.client.API.PullRequestsListPullRequestsWithCommit(ctx, sha, nil) | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| for _, pr := range prs { | ||
| if pr.GetState() != "closed" { | ||
| if pr.GetState() != string(state) { |
There was a problem hiding this comment.
Could you check Pull Request's UpdatedAt?
How to handle when multiple pull requests are associated
Choose the latest updated pr
I don't know the order of prs
There was a problem hiding this comment.
Done: d359a60 (#390)
Signed-off-by: micnncim <micnncim@gmail.com>
|
@suzuki-shunsuke Thanks for your quick review! When are planning to release a new version? |
|
I have already released v3.4.0. |
|
I missed the release. Thanks a lot again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GitHub no longer shows commit comments in the pull request timeline 1, it needs to find a PR associated with a commit in a push event and then post a PR comment if found in order to show comments in the pull request timeline.
See #387 for more details.
Footnotes
https://github.blog/changelog/2022-08-04-commit-comments-no-longer-appear-in-the-pull-request-timeline ↩