Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to supply a platform specific header for duk_features.h.in #42

Closed
svaarala opened this issue Aug 30, 2014 · 1 comment
Closed
Milestone

Comments

@svaarala
Copy link
Owner

Currently duk_features.h.in detects all platforms Duktape works on, which is non-modular and becomes progressively more difficult to maintain over time. In addition to standard platforms (C99 or close) there are exotic platforms which require much more hackery than others, and closed platforms which may never get support in the mainline as the toolchain may not be publicly available. At the moment several users need to maintain a patch for Duktape to get the feature detection come out right.

The user should be able to provide a custom header which would cause Duktape to skip all platform detection and rely on the user header for platform feature detection, inclusion of system headers, etc. This allows more exotic and closed platforms to be supported without making the mainline source more difficult to maintain.

On a related note, it would be nice to be able to provide the necessary functions to support the Date built-in outside of the master branch. Date built-in is a major component which often needs platform modifications, and collecting all the variants in the mainline is awkward in the longer term.

@svaarala
Copy link
Owner Author

svaarala commented Nov 2, 2014

There's now a more concrete alternative so I'll close this.

@svaarala svaarala closed this as completed Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant