Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable check-migrations until cms plugins have been updated #21

Closed
sveetch opened this issue Jan 30, 2023 · 2 comments
Closed

Disable check-migrations until cms plugins have been updated #21

sveetch opened this issue Jan 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@sveetch
Copy link
Owner

sveetch commented Jan 30, 2023

A lot of cms plugins have not been updated for Django>=4.0 which result in a pending migration for a change on related_name, i've fixed it for the ckeditor plugin but at least there is fobi, snippet and djangocms_picture which have this issue in Bireli requirements.

For now we need to disable check-migrations task from quality task.

And then after we will have to pull request these applications to fix the migration issue or wait a possible fix release.

@sveetch sveetch added the bug Something isn't working label Jan 30, 2023
@sveetch
Copy link
Owner Author

sveetch commented Jan 30, 2023

Disabled in 0.3.3-pre.1. Keeping the issue opened to follow cms plugins updates

@sveetch sveetch added enhancement New feature or request and removed bug Something isn't working labels Jan 30, 2023
@sveetch
Copy link
Owner Author

sveetch commented Feb 1, 2023

Finally we will trying something else in 0.3.3-pre.4. We will use a "white list" instead of disabling task.

We explicitly check for migrations from all apps from django-apps directory so this won't try to scan everything from INSTALLED_APPS, only the one from django-apps.

It should be enough and finally seems more accurate than to also scan packages in an internal project quality. However we lose the capacity to see failures from packages that miss their own migrations.

@sveetch sveetch closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant