Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing row.html and column.html templates in 0.8.0 #46

Open
mpasternak opened this issue Aug 8, 2020 · 3 comments
Open

Missing row.html and column.html templates in 0.8.0 #46

mpasternak opened this issue Aug 8, 2020 · 3 comments
Labels

Comments

@mpasternak
Copy link
Contributor

Hi,

this commit:

78759aa#diff-1a77a0ef39514b22b57499cd39df30c1

had both row.html and column.html and it looks like they're missing in release 0.8.0. Could you please add those files and release it to PyPI? Thanks!

@sveetch
Copy link
Owner

sveetch commented Aug 12, 2020

Yep, this is because grid column and row are already implemented through grid layout components:

https://crispy-forms-foundation.readthedocs.io/en/latest/layout/grid.html

@mpasternak
Copy link
Contributor Author

Silly me! Instead of importing crispy_forms_foundation.layout, I was importing from crispy_forms.layout. This gave me error about missing foundation6/layout/col.html and such.

Perhaps this bug I encountered could be documented somewhere, how do you think?

@sveetch
Copy link
Owner

sveetch commented Aug 13, 2020

I could write a warning line about this in documentation, it won't cost anything, still i don't know i will have the heart to release documentation just for this :)

I will keep this issue open to remember it for a possible next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants