Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Sass icon map can be corrupted #13

Open
sveetch opened this issue Aug 22, 2021 · 2 comments
Open

Generated Sass icon map can be corrupted #13

sveetch opened this issue Aug 22, 2021 · 2 comments
Labels

Comments

@sveetch
Copy link
Owner

sveetch commented Aug 22, 2021

Sometime a icon item from icomoon can have an invalid name like foo, bar because of its tags, and it should be something like foo, bar or foobar but never something we invalid characters for a Sass variables (no space, no ,, no $, etc..).

At least, the command line should validate each name and raise a warning or a blocking error when there is some invalid name.

This is to avoid unexpected issues with generated Sass map for users which forgot about the valid variable name requirement.

@sveetch sveetch added the bug label Aug 22, 2021
@sveetch
Copy link
Owner Author

sveetch commented Aug 22, 2021

Also it would be worth to mention about this requirement in documentation.

@sveetch
Copy link
Owner Author

sveetch commented Aug 22, 2021

Note: From Icomoon interface, we can see invalid name from a project in the tab "Generate SVG & more", the name is aside the displayed glyph for each icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant