Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export some internal functions #10025

Closed
AlexRMU opened this issue May 24, 2023 · 1 comment
Closed

Export some internal functions #10025

AlexRMU opened this issue May 24, 2023 · 1 comment

Comments

@AlexRMU
Copy link

AlexRMU commented May 24, 2023

Describe the problem

For example, I want to disable or change csfr or csp for different routes. To do this, I disable it in the settings, copy this functionality from the source and use it manually as I need. But if the implementation changes, I won't be able to find out about it.
Perhaps there are many more such functions.

Describe the proposed solution

I suggest exporting some internal functions as utilities.

Alternatives considered

No response

Importance

nice to have

Additional Information

Perhaps modularity and optionality are more suited to the Svelte ideology.

@Conduitry
Copy link
Member

There's already #6784 for CSRF. There are a number of other CSP-related issues.

As a rule, we don't like to expose internal functions just because we can. That ties us to that API and prevents certain kinds of refactoring without it being a breaking change. The API of the internal function is also likely not designed with ease-of-use by an end-user in mind. If you have specific feature requests that are more actionable, please open separate issues for them instead.

@Conduitry Conduitry closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants