-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node adaptor does not serve contents with any compression #345
Comments
brotli might be better yet |
When I run |
Sapper used Polka/Express. There's half a dozen open PRs there for brotli support: https://github.com/expressjs/compression/pulls?q=brotli+is%3Apr+is%3Aopen+. We might have to wait on that and just do gzip for now Though Kit uses the built-in Node server. But I'm not sure if we should stick with it since we'd need to figure out how to cache the response after compressing it. https://nodejs.org/api/zlib.html#zlib_compressing_http_requests_and_responses |
If it's switched to using Express/Polka, should the adapter name be changed to match? It could reduce confusion with regards to required runtime dependencies of the adapted output. |
By default the node adaptor should compress responses, right now it does not. Compared to sapper this is a regression.
The text was updated successfully, but these errors were encountered: