Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable svelte-package publishing instructions #7804

Closed
silverbucket opened this issue Nov 25, 2022 · 2 comments
Closed

Add ability to disable svelte-package publishing instructions #7804

silverbucket opened this issue Nov 25, 2022 · 2 comments
Labels
feature request New feature or request pkg:svelte-package Issues related to svelte-package ready to implement please submit PRs for these issues!
Milestone

Comments

@silverbucket
Copy link

silverbucket commented Nov 25, 2022

Describe the problem

I'm working on a shared component library to use with a number of different projects. The release process of this library needs to be different than a simple npm publish of the package directory. So the message displayed is incorrect and causes confusion among developers.

Describe the proposed solution

Add ability to remove the publishing instructions, (i.e. -s silent mode)

Though it's nice to have the basic text:

$ npx svelte-package
src/lib -> package
Successfully built 'shared-svelte-components' package.

It's this part after, that can go against any custom workflow:

To publish it to npm:
  cd package
  npm publish

In my case we need to actually commit and tag the release in git and install via a git URL so this instruction is entirely incorrect for us (and potentially dangerous).

Ideally it would be even better have the option to have the package.json that is generated set to private by default.

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response

@dummdidumm dummdidumm added feature request New feature or request pkg:svelte-package Issues related to svelte-package labels Nov 25, 2022
@dummdidumm dummdidumm added this to the post-1.0 milestone Nov 25, 2022
@benmccann benmccann added the ready to implement please submit PRs for these issues! label Jan 28, 2023
@braebo
Copy link
Member

braebo commented Feb 9, 2023

I encountered this recently when a junior team member was mislead by this message (we use a changeset github workflow insted).

Should we remove the message entirely?

Or perhaps replace it with a link?

src/lib -> package
Successfully built 'shared-svelte-components' package.
See https://kit.svelte.dev/docs/packaging for more information.

I'm leaning towards the former. Even if someone is new to this, chances are they're at least aware of the docs.

@gtm-nayan
Copy link
Contributor

Publish instructions are no longer logged with @sveltejs/package v2. (#8922)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request pkg:svelte-package Issues related to svelte-package ready to implement please submit PRs for these issues!
Projects
None yet
Development

No branches or pull requests

5 participants