Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) TypeScript 5.0 #1919

Merged
merged 11 commits into from Mar 31, 2023
Merged

(chore) TypeScript 5.0 #1919

merged 11 commits into from Mar 31, 2023

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Mar 7, 2023

TODOs:

Note to self: We don't need to handle the ignoreDeprecations situation because we parse the tsconfig but don't use its diagnostics, which is the only time where errors could be thrown because of an invalid tsconfig. It doesn't matter down the line for the other parts of language tools.

@dummdidumm
Copy link
Member Author

Let's wait for 5.0.3 before merging/releasing this so the TS team had the opportunity to iron out the worst bugs - this being such a big release there are likely more of those than usual.

@dummdidumm dummdidumm marked this pull request as ready for review March 31, 2023 12:42
@dummdidumm dummdidumm merged commit 66fbb9a into sveltejs:master Mar 31, 2023
2 checks passed
@dummdidumm dummdidumm deleted the typescript-5 branch March 31, 2023 13:24
@janosh
Copy link
Contributor

janosh commented Apr 4, 2023

Just tried it out. Resolution works great on packages using "moduleResolution": "bundler". Thanks!

Does this extension have control over whether command-clicking an import opens the .d.ts file or the actual component? Currently it's the former but would prefer latter.

@dummdidumm
Copy link
Member Author

It does not. For that the producer of the d.ts file would need to create a declaration map, and that's tricky/cumbersome to set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants