Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css autocompletion is not working with some self-closing tags #254

Closed
madacol opened this issue Jul 1, 2020 · 3 comments
Closed

Css autocompletion is not working with some self-closing tags #254

madacol opened this issue Jul 1, 2020 · 3 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@madacol
Copy link

madacol commented Jul 1, 2020

Issue Type: Bug

Doesn't work

image

works

image

code:

<div>
    <i/>
</div>

<style>
    div {
        marg
    }
</style>

Extension version: 100.0.2
VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:08.304Z)
OS version: Linux x64 4.15.0-108-generic

System Info
Item Value
CPUs Intel(R) Core(TM) i7-3820 CPU @ 3.60GHz (8 x 3525)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off_ok
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 15.59GB (4.52GB free)
Process Argv --no-sandbox --unity-launch
Screen Reader no
VM 0%
DESKTOP_SESSION ubuntu
XDG_CURRENT_DESKTOP Unity
XDG_SESSION_DESKTOP ubuntu
XDG_SESSION_TYPE x11
@madacol
Copy link
Author

madacol commented Jul 1, 2020

Sorry, it seems <i/> is not standard html

It is not a self closing tag, so replacing with <i></i> works fine


Although something is definitely failing to tell what's the real issue, just not sure it's this software

@madacol madacol closed this as completed Jul 1, 2020
@madacol
Copy link
Author

madacol commented Jul 1, 2020

Ok I just found another case.

There seems to be a general problem with some self closing tags

Doesn't work

If the Nested component is rendered at the root level and is self closed
image

Works

if the Nested component has a closing tag at root level, or is inside another html tag
image

@madacol madacol reopened this Jul 1, 2020
@madacol madacol changed the title Css autocompletion is not working if and <i/> tag is present Css autocompletion is not working with some self-closing tags Jul 1, 2020
@dummdidumm
Copy link
Member

The underlying issue is #194 , which is fixed on nightly builds already and will be deployed to prod soon.

@dummdidumm dummdidumm added bug Something isn't working Fixed Fixed in master branch. Pending production release. labels Jul 1, 2020
@madacol madacol closed this as completed Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants