Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coffeescript sourcemap #416

Merged
merged 1 commit into from Sep 30, 2021
Merged

fix: coffeescript sourcemap #416

merged 1 commit into from Sep 30, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 27, 2021

Fixes #413

The coffeescript transformer was using an old sourcemap format I believe. It was something like:

SourceMap {
  lines: [
    LineMap { line: 0, columns: [Array] },
    <1 empty item>,
    LineMap { line: 2, columns: [Array] }
  ]
}

This change uses the v3SourceMap string from the compile result instead.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

@kaisermann kaisermann self-assigned this Sep 30, 2021
@kaisermann kaisermann added the bug Something isn't working label Sep 30, 2021
@kaisermann kaisermann merged commit 6cc54b6 into sveltejs:main Sep 30, 2021
@kaisermann
Copy link
Member

Thanks! Released in v4.9.6 🎉

@bluwy bluwy deleted the fix-coffeescript branch September 30, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get error "Cannot read properties of undefined (reading 'length')" in sveltekit when use coffeescript
2 participants