Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 5: cmdk-sv started breaking on 5.0.0-next.55 #10492

Closed
zhihengGet opened this issue Feb 16, 2024 · 4 comments
Closed

Svelte 5: cmdk-sv started breaking on 5.0.0-next.55 #10492

zhihengGet opened this issue Feb 16, 2024 · 4 comments
Labels
Milestone

Comments

@zhihengGet
Copy link

zhihengGet commented Feb 16, 2024

Describe the bug

somehow i cant use https://github.com/huntabyte/cmdk-sv on latest version 5.0.0-next.55

since it was working with 5.0.0-next.53 i think i should raise it here or probably just need to update that lib

Reproduction

  1. start a svelte 5.0.0-next.55 and download npm install cmdk-sv
<script lang="ts">
	import { Command } from 'cmdk-sv';
</script>

<Command.Root label="Command Menu">
	<Command.Input />
	<Command.List>
		<Command.Empty>No results found.</Command.Empty>

		<Command.Group heading="Letters">
			<Command.Item>a</Command.Item>
			<Command.Item>b</Command.Item>
			<Command.Separator />
			<Command.Item>c</Command.Item>
		</Command.Group>

		<Command.Item>Apple</Command.Item>
	</Command.List>
</Command.Root>

Logs

✘ [ERROR] Invalid assignment target

    node_modules/.pnpm/cmdk-sv@0.0.13_svelte@5.0.0-next.55/node_modules/cmdk-sv/dist/cmdk/components/Command.svelte:82:30:
      82 │       $.mutate_store(stateStore, $.untrack($stateStore).value() = ...
         ╵                                  ^

9:12:20 PM [vite] error while updating dependencies:
Error: Build failed with 1 error:
node_modules/.pnpm/cmdk-sv@0.0.13_svelte@5.0.0-next.55/node_modules/cmdk-sv/dist/cmdk/components/Command.svelte:82:30: ERROR: Invalid assignment target
    at failureErrorWithLog (/home/httpswwwsveltelabdev-dcnb/node_modules/.pnpm/esbuild@0.19.12/node_modules/esbuild/lib/main.js:1641:15)
    at eval (/home/httpswwwsveltelabdev-dcnb/node_modules/.pnpm/esbuild@0.19.12/node_modules/esbuild/lib/main.js:1049:25)
    at eval (/home/httpswwwsveltelabdev-dcnb/node_modules/.pnpm/esbuild@0.19.12/node_modules/esbuild/lib/main.js:1517:9)

System Info

os

Severity

annoyance

@zhihengGet zhihengGet changed the title Svelte 5: CMD-SV started breaking on 5.0.0-next.55 Svelte 5: cmdk-sv started breaking on 5.0.0-next.55 Feb 16, 2024
@dummdidumm
Copy link
Member

Sounds related to #10477

@dummdidumm dummdidumm added this to the 5.0 milestone Feb 16, 2024
@dummdidumm dummdidumm added the bug label Feb 16, 2024
@ndom91
Copy link

ndom91 commented Feb 20, 2024

Can I provide any further info? Running into this as well

@ndom91
Copy link

ndom91 commented Feb 20, 2024

@zhihengGet I don't know if something old is cached, but it seems to be working again for me under next.64.

Let me know if its working for you there as well 🙏

@zhihengGet
Copy link
Author

zhihengGet commented Feb 20, 2024

@zhihengGet I don't know if something old is cached, but it seems to be working again for me under next.64.

Let me know if its working for you there as well 🙏

yep works for me as well, @dummdidumm feel free to close this though idk which update fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants