Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reactive assignments not triggering a rerender #10828

Closed
nmathew98 opened this issue Mar 18, 2024 · 3 comments
Closed

reactive assignments not triggering a rerender #10828

nmathew98 opened this issue Mar 18, 2024 · 3 comments
Labels
awaiting submitter needs a reproduction, or clarification

Comments

@nmathew98
Copy link

Describe the bug

reactive assignments are triggering a rerender only sometimes

see:

Reproduction

  • create a thread
  • view the thread
  • share a thought
  • reply to the thought
  • result: Value is not cleared

but

  • create a thread
  • view the thread
  • share a thought
  • result: Input value is cleared

Logs

No response

System Info

tested on Safari, macOS Sonoma

see:
- https://github.com/nmathew98/qwery/blob/dev/packages/example-svelte/src/Thread.svelte#L153
- https://github.com/nmathew98/qwery/blob/dev/packages/example-svelte/src/Thread.svelte#L275

Severity

blocking all usage of svelte

@dummdidumm
Copy link
Member

Please provide a proper minimum reproduction, the link has way too much side stuff going on.

@dummdidumm dummdidumm added the awaiting submitter needs a reproduction, or clarification label Mar 18, 2024
@nmathew98
Copy link
Author

alright will get a stackblitz going

@nmathew98
Copy link
Author

nmathew98 commented Mar 20, 2024

hey so it looks like its because the updates were done inside of async functions (both reactive assignments and store updates break)?

if I were to make the functions themselves sync but perform the updates within a promise I get the same result but if the functions are sync (just commenting out the call to sleep but leaving depthOne and depthTwo marked as async) then no issues

adapting the stackblitz:
image

and the result is:

  • things break after depthOne: image

stackblitz: https://stackblitz.com/edit/svelte-bugs-10829-10828-10827?file=src%2FApp.svelte

@nmathew98 nmathew98 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting submitter needs a reproduction, or clarification
Projects
None yet
Development

No branches or pull requests

2 participants