Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility warning: href shouldn't be required when aria-disabled="true" #11733

Closed
jamesst20 opened this issue May 22, 2024 · 0 comments · Fixed by #11737
Closed

Accessibility warning: href shouldn't be required when aria-disabled="true" #11733

jamesst20 opened this issue May 22, 2024 · 0 comments · Fixed by #11737
Labels
a11y

Comments

@jamesst20
Copy link

jamesst20 commented May 22, 2024 •
edited

Describe the bug

Capture d’écran, le 2024-05-22 à 11 35 38

Popular librairies such as https://ddnexus.github.io/pagy/ are doing it the same exact way as well. Maybe they got it wrong. Aria standards are not well documented.

Reproduction

  <span class="page prev disabled">
    <a role="link" aria-disabled="true" tabindex="-1" aria-label="Back">←</a>
  </span>

System Info

Svelte 5 next 135

Severity

annoyance
@paoloricciuti paoloricciuti mentioned this issue May 22, 2024
Merged
5 tasks
dummdidumm pushed a commit that referenced this issue May 23, 2024
@paoloricciuti
fix: don't warn on link without href if aria-disabled (#11737)
e73b133 
Also don't warn on a tag without a href attribute and link role
fixes #11733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't warn on link without href if aria-disabled paoloricciuti/svelte
2 participants
@jamesst20 @dummdidumm