Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bind:clientWidth shows up in SSR #2339

Closed
Rich-Harris opened this issue Mar 29, 2019 · 1 comment · Fixed by #2877
Closed

bind:clientWidth shows up in SSR #2339

Rich-Harris opened this issue Mar 29, 2019 · 1 comment · Fixed by #2877
Labels

Comments

@Rich-Harris
Copy link
Member

it shouldn't

@Rich-Harris Rich-Harris added this to the 3.x milestone Mar 29, 2019
@Conduitry
Copy link
Member

Probably none of the read-only bindings should be written out in SSR. This includes the four dimension bindings (offset/client width/height), but also a few of the media bindings and maybe some others. There's an is_readonly value that's calculated for each binding, but only for the DOM renderer. Perhaps this should be moved to the common (unwrapped) Binding AST class so that the SSR renderer can also make use of it and skip them when appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants