Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 3 with customElement=true - fails without <svelte:options /> #2821

Closed
georges-gomes opened this issue May 19, 2019 · 4 comments
Closed

Comments

@georges-gomes
Copy link

georges-gomes commented May 19, 2019

Hi,

With customElement=true

The following svelte

<script>
	let name = 'world';
</script>

<h1>Hello {name}!</h1>

fails with

pos is undefined

adding <svelte:options /> (I'm good without tag= because it's export default 👍)
fixes the problem

<svelte:options />
<script>
	let name = 'world';
</script>

<h1>Hello {name}!</h1>
@varholak-peter
Copy link
Contributor

Could you fix your code formatting, please? :)

@georges-gomes
Copy link
Author

Pretty messed up indeed !!!
Good now

@georges-gomes georges-gomes changed the title Svelte 3 with customElement=true, attributes/properties not used anymore Svelte 3 with customElement=true - fails without <svelte:options /> May 19, 2019
@georges-gomes
Copy link
Author

Wrong problem. Only <svelte:options /> is relevant.

@Rich-Harris
Copy link
Member

Released 3.4.2 with the fix — thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants