Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary $$invalidate calls during component creation #4018

Closed
mrkishi opened this issue Nov 30, 2019 · 2 comments · Fixed by #4069
Closed

Unnecessary $$invalidate calls during component creation #4018

mrkishi opened this issue Nov 30, 2019 · 2 comments · Fixed by #4069

Comments

@mrkishi
Copy link
Member

mrkishi commented Nov 30, 2019

There's no need to instrument assignments with calls to $$invalidate inside the main instance() function body as all variables are initially set to dirty already.

It wouldn't be a huge improvement, but it's unnecessary work nonetheless.

@mrkishi
Copy link
Member Author

mrkishi commented Nov 30, 2019

A straight ahead tweak on the current ast walk comes upon two complications: labelled statements and store reassignments. They need to be instrumented regardless of being in the main control flow or not.

@mrkishi
Copy link
Member Author

mrkishi commented Dec 7, 2019

PR incoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants